Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

835 add left button to ion header #840

Merged
merged 12 commits into from
Sep 28, 2023
Merged

835 add left button to ion header #840

merged 12 commits into from
Sep 28, 2023
+165 −1

Conversation

allan-chagas-brisa
Copy link
Contributor

@allan-chagas-brisa allan-chagas-brisa commented Sep 26, 2023 •
edited
Loading

Issue Number

fix #835

Proposed Changes

  • Addition of a ion-button to the header;
  • New event emitter to emit when the header button is clicked;
  • On the service there is a subscribe that listens to this emitter and notify the bodyComponent of the click action.

How to Test

run yarn test modal

Screenshots

image

View Storybook

storybook

Compliance

  • I have verified that this change complies with our code and contribution policies.
  • I have verified that this change does not cause regressions and does not affect other parts of the code.

@allan-chagas-brisa allan-chagas-brisa linked an issue Sep 26, 2023 that may be closed by this pull request
Add left button to ion-header #835
Closed
@allan-chagas-brisa allan-chagas-brisa self-assigned this Sep 26, 2023
iurynogueira
iurynogueira requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@iurynogueira iurynogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jAllanOli, good tests and logical to fix this problem.

projects/ion/src/lib/modal/component/modal.component.spec.ts Show resolved Hide resolved
projects/ion/src/lib/modal/component/modal.component.spec.ts Outdated Show resolved Hide resolved
projects/ion/src/lib/modal/component/modal.component.spec.ts Outdated Show resolved Hide resolved
projects/ion/src/lib/modal/component/modal.component.spec.ts Outdated Show resolved Hide resolved
iurynogueira
iurynogueira approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@iurynogueira iurynogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@allan-chagas-brisa allan-chagas-brisa merged commit 63024a6 into main Sep 28, 2023
3 checks passed
@allan-chagas-brisa allan-chagas-brisa deleted the 835-add-left-button-to-ion-header branch September 28, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-moreira-brisa danilo-moreira-brisa danilo-moreira-brisa approved these changes

@iurynogueira iurynogueira iurynogueira approved these changes

Assignees

@allan-chagas-brisa allan-chagas-brisa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add left button to ion-header
3 participants
@allan-chagas-brisa @iurynogueira @danilo-moreira-brisa